[LiveComponent] Support for liveProp union type #3150
+78
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
Kocal
requested changes
Oct 29, 2025
Member
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Hi and thanks for the contribution!
This new feature needs to be covered with some tests, and the CHANGELOG.md must be updated too.
Also, you only support the TypeInfo path and not the legacy PropertyInfo path, but I think that's fine.
carsonbot
added
Status: Needs Work
carsonbot
added
Status: Needs Review
smnandre
reviewed
Nov 15, 2025
src/LiveComponent/CHANGELOG.md
Outdated
|
|
||
| - Add support for `LiveProp` union types in Live Components. | ||
| `LiveComponentMetadataFactory` can now create `liveProp` metadata for union types. | ||
| Note: This feature only works when using a custom `hydrate` and `dehydrate` implementation. |
Member
There was a problem hiding this comment.
Hey @kevinmade ! Could you add a test or two covering the cases "not supposed to work" (ie: when hydrate and/or dehydrate are missing ?)
Author
There was a problem hiding this comment.
I thought a hydrator and dehydrator were required for my change, but this had something to do with my own use case, where the union had a type that wasn't a hydratable. I’ve removed the note from the changelog and added a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for liveProp union types in Live Components. Previously, using a union type would throw an exception. With this change
LiveComponentMetadataFactorywill be able to create liveProp metadata for union types, but will only work in combination with a custom hydrate and dehydrate implementation.